Add a new annotation and an interceptor to control and check content … #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…size of bodies and files
amanteaux
requested changes
Sep 17, 2024
plume-web-jersey/src/main/java/com/coreoz/plume/jersey/security/control/ContentSizeLimit.java
Outdated
Show resolved
Hide resolved
...web-jersey/src/main/java/com/coreoz/plume/jersey/security/control/ContentControlFeature.java
Show resolved
Hide resolved
...web-jersey/src/main/java/com/coreoz/plume/jersey/security/control/ContentControlFeature.java
Outdated
Show resolved
Hide resolved
...web-jersey/src/main/java/com/coreoz/plume/jersey/security/control/ContentControlFeature.java
Outdated
Show resolved
Hide resolved
...web-jersey/src/main/java/com/coreoz/plume/jersey/security/control/ContentControlFeature.java
Outdated
Show resolved
Hide resolved
...web-jersey/src/main/java/com/coreoz/plume/jersey/security/control/ContentControlFeature.java
Outdated
Show resolved
Hide resolved
...web-jersey/src/main/java/com/coreoz/plume/jersey/security/control/ContentControlFeature.java
Outdated
Show resolved
Hide resolved
...web-jersey/src/main/java/com/coreoz/plume/jersey/security/control/ContentControlFeature.java
Outdated
Show resolved
Hide resolved
...web-jersey/src/main/java/com/coreoz/plume/jersey/security/control/ContentControlFeature.java
Outdated
Show resolved
Hide resolved
plume-web-jersey/src/test/java/com/coreoz/plume/jersey/control/ContentSizeLimitTest.java
Outdated
Show resolved
Hide resolved
… size provided by the annotation
… header is already higher than the limit
benoitvasseur
force-pushed
the
content-size
branch
2 times, most recently
from
c7b35bb to
e654911
Compare
benoitvasseur
force-pushed
the
content-size
branch
from
e654911 to
f6a9e0f
Compare
amanteaux
requested changes
Sep 19, 2024
...web-jersey/src/main/java/com/coreoz/plume/jersey/security/control/ContentControlFeature.java
Outdated
Show resolved
Hide resolved
...web-jersey/src/main/java/com/coreoz/plume/jersey/security/control/ContentControlFeature.java
Outdated
Show resolved
Hide resolved
plume-web-jersey/src/test/java/com/coreoz/plume/jersey/control/TestContentSizeResource.java
Show resolved
Hide resolved
benoitvasseur
force-pushed
the
content-size
branch
from
52ed253 to
295ce44
Compare
amanteaux
reviewed
Sep 23, 2024
Comment on lines
61
to
66
| Integer headerContentLength; | ||
| try { | ||
| headerContentLength = Integer.parseInt(context.getHeaders().getFirst(HttpHeaders.CONTENT_LENGTH)); | ||
| } catch (NumberFormatException e) { | ||
| headerContentLength = maxSize; // default value for GET or chunked body | ||
| } |
There was a problem hiding this comment.
C'est un peu cracra, tu vas lever des exceptions à chaque requête GET.
Ce serait mieux de faire le parsing seulement si le header est non nul.
Par exemple :
Suggested change
| Integer headerContentLength; | |
| try { | |
| headerContentLength = Integer.parseInt(context.getHeaders().getFirst(HttpHeaders.CONTENT_LENGTH)); | |
| } catch (NumberFormatException e) { | |
| headerContentLength = maxSize; // default value for GET or chunked body | |
| } | |
| int headerContentLength = maxSize; // default value for GET or chunked body | |
| String contentLengthHeader = context.getHeaders().getFirst(HttpHeaders.CONTENT_LENGTH); | |
| if (contentLengthHeader) { | |
| try { | |
| headerContentLength = Integer.parseInt(contentLengthHeader); | |
| } catch (NumberFormatException e) { | |
| logger.warn("Wrong content length header received: {}", contentLengthHeader); | |
| } | |
| } |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…size of bodies and files
Will need an update after jersey migration to jakarta